CI was triggered for the PR since I'm a contributor now after you merged my first PR. Secrets aren't available for such though, hence CI failing.

Personally you shouldn't have the workflow try to login/publish PRs, only build them.

Personally you shouldn't have the workflow try to login/publish PRs, only build them.

yeah, i am meant to fix that :D

yeah, i am meant to fix that :D

For a project I maintain, I have simpler workflows like these:

• Push event to the primary branch (builds image and publishes it)
• Scheduled workflow runs (builds and publishes on a schedule)
• PR event for building the image and running tests

I find that's a bit easier to grok and manage from a top-level. While they each share common reusable workflows that are more verbose:

• Image building
• Image publishing
• Image testing

Most other projects I see though just litter if conditionals on if it's a PR triggering the event to prevent doing actions like publishing the image, so it's up to you 😅

In that project there's a common build workflow, so PRs will build and test only AMD64 (if tests pass, only then do we bother with the ARM64 build which is quite slow), but the publish workflow will take a build (from cache if possible) and publish the image for both platforms.

I find that's a bit easier to grok and manage from a top-level. While they each share common reusable workflows that are more verbose

yeah, like the idea of that.

Most other projects I see though just litter if conditionals on if it's a PR triggering the event to prevent doing actions like publishing the image, so it's up to you 😅

yeah.. it's the logical first step. i start hating the if conditionals when you start to need to && them together though.
btw ..i did add some dumb if conditions to the login/push steps and the merge workflow after merging your ci refactoring pr in the hopes that ci is more useful for you. #164